refactor(dev): remove errorName from Error classes #5769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
approved these changes
Oct 11, 2024
chengoramazon
force-pushed
the
chengora/refactor-errors
branch
from
0e93a97 to
124dc72
Compare
justinmk3
reviewed
Oct 14, 2024
| ) | ||
| }) | ||
|
|
||
| it('should handle default errors', async function () { |
Contributor
There was a problem hiding this comment.
Each of these tests is near-identical. Part of the job of developing this project is to look for ways to reduce duplicate code and increase maintainability. Hundreds of lines of duplicate code is unacceptable. Please keep this in mind for future contributions.
justinmk3
suggested changes
Oct 14, 2024
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
latest push has lots of duplicate code
chengoramazon
force-pushed
the
chengora/refactor-errors
branch
from
124dc72 to
483e717
Compare
willyyhuang
approved these changes
Oct 15, 2024
justinmk3
reviewed
Oct 15, 2024
| } | ||
|
|
||
| runs.forEach((run) => { | ||
| it(`should handle ${run.name}`, async function () { |
Contributor
There was a problem hiding this comment.
For reference this is one way of de-duplicating tests, but it would also be fine to have a bunch of manally-declared it() blocks which call a common function.
Contributor
|
Thank you for this clean up! |
tverney
pushed a commit
to tverney/aws-toolkit-vscode
that referenced
this pull request
Oct 21, 2024
## Problem - Static `errorName` is unnecessary in feature dev error classes. It also causes error code mismatches some of errorName which result in wrong state. ## Solution - Remove `errorName` from error classes - use class name match to ensure error handled correctly. - Add unit tests to cover all the error cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
errorNameis unnecessary in feature dev error classes. It also causes error code mismatches some of errorName which result in wrong state.Solution
errorNamefrom error classesLicense: I confirm that my contribution is made under the terms of the Apache 2.0 license.